⚡ Remove --cov from pytest.ini_options
#3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for developers to weigh in on, but makes total sense to me! Nice! |
jamshale
reviewed
Feb 13, 2025
ff137
force-pushed
the
remove-cov-from-pytest-config
branch
from
42e4d9a to
a6b5953
Compare
Signed-off-by: ff137 <[email protected]>
ff137
force-pushed
the
remove-cov-from-pytest-config
branch
from
a6b5953 to
253860b
Compare
jamshale
approved these changes
Feb 13, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer experience improvement:
Speeds up local test runs, especially when only wanting to run a few tests at a time
Previously, running a single unit test took me 7.5 seconds, and now it takes 0.5 seconds.
This is because it takes ~7 seconds to generate the coverage report (in terminal and xml file) for the whole acapy_agent folder, and the pyproject.toml (
[tool.pytest.ini_options]) configures that all pytest commands include a coverage request.This is hugely unnecessary to be forced on the developer every time they type pytest
If a developer wants to see a coverage report, they can add --cov at the end.
Impact: running tests locally are faster, and a developer will have to now type --cov if they ever want to see a coverage report.
Also, test output is more readable now, since it won't always include 100s of lines of coverage info.
No modification necessary for the github workflows, since they manually specify to run with --cov