-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add biome.json and remove redundant config files #2181
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
|
Hey @sairanjit , just checking on the status of this PR? Do you think you can finish it up soon-ish? |
Yes @TimoGlastra I will complete it this week |
…re/biome-js Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
8f8fe80
to
7f5792d
Compare
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
@TimoGlastra This PR is ready now |
Summary
Picking forward from #2175
Use biomejs for Linting and formatting Switch from prettier + eslint to Biome #2145
Rules configured
✅ @typescript-eslint/no-unsafe-declaration-merging
✅ @typescript-eslint/no-use-before-define
✅ no-console
✅ @typescript-eslint/consistent-type-imports
✅ @typescript-eslint/no-non-null-assertion
✅ no-restricted-imports
✅ no-restricted-globals
✅ @typescript-eslint/no-unused-vars
Rules set as
⚠️ import/no-extraneous-dependencies - Available from version
warn
2.0.0
-and also we have a issue here 💅 Lint rule
noUndeclaredDependencies
doesn't check nearestpackage.json
depedencies with npm workspace biomejs/biome#4992Rules Not available
❌ @typescript-eslint/explicit-function-return-type
❌ @typescript-eslint/explicit-module-boundary-types
❌ @typescript-eslint/explicit-member-accessibility
❌ @typescript-eslint/ban-ts-comment
❌ @typescript-eslint/no-floating-promises
❌ import/no-cycle
❌ import/newline-after-import
❌ import/order
❌ no-restricted-syntax
Tasks
eslint-disable-next-line
tobiome-ignore
Notes
TSyringe
so had to make"useImportType": "off"