Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add biome.json and remove redundant config files #2181

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

sairanjit
Copy link
Contributor

@sairanjit sairanjit commented Feb 7, 2025

Summary

Picking forward from #2175

  • Use biomejs for Linting and formatting Switch from prettier + eslint to Biome #2145

  • Rules configured
    ✅ @typescript-eslint/no-unsafe-declaration-merging
    ✅ @typescript-eslint/no-use-before-define
    ✅ no-console
    ✅ @typescript-eslint/consistent-type-imports
    ✅ @typescript-eslint/no-non-null-assertion
    ✅ no-restricted-imports
    ✅ no-restricted-globals
    ✅ @typescript-eslint/no-unused-vars

    Rules set as warn
    ⚠️ import/no-extraneous-dependencies - Available from version 2.0.0-
    and also we have a issue here 💅 Lint rule noUndeclaredDependencies doesn't check nearest package.json depedencies with npm workspace biomejs/biome#4992

  • Rules Not available
    ❌ @typescript-eslint/explicit-function-return-type
    ❌ @typescript-eslint/explicit-module-boundary-types
    ❌ @typescript-eslint/explicit-member-accessibility
    ❌ @typescript-eslint/ban-ts-comment
    ❌ @typescript-eslint/no-floating-promises
    ❌ import/no-cycle
    ❌ import/newline-after-import
    ❌ import/order
    ❌ no-restricted-syntax

Tasks

  • Fix formatting
  • Fix Linting
  • Migrate initial required rules to biomejs
  • Update eslint-disable-next-line to biome-ignore
  • Update the scripts in package.json
  • Update commands in CI/CD
  • Update test snapshots

Notes

@sairanjit sairanjit requested a review from a team as a code owner February 7, 2025 05:41
Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: a45718f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sairanjit sairanjit marked this pull request as draft February 7, 2025 05:42
@TimoGlastra
Copy link
Contributor

Hey @sairanjit , just checking on the status of this PR? Do you think you can finish it up soon-ish?

@sairanjit
Copy link
Contributor Author

Hey @sairanjit , just checking on the status of this PR? Do you think you can finish it up soon-ish?

Yes @TimoGlastra I will complete it this week

…re/biome-js

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
@sairanjit sairanjit marked this pull request as ready for review February 28, 2025 08:18
@sairanjit
Copy link
Contributor Author

@TimoGlastra This PR is ready now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants