Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace auc with owut for 24.10 releases #1199

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented Feb 6, 2025

The cleaner implementation is to handle this on the clients. @efahl do you work on the LuCI app? If not we should consider dropping it or find someone else to maintain it.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.22%. Comparing base (5e65dec) to head (db52e19).
Report is 208 commits behind head on main.

Files with missing lines Patch % Lines
asu/package_changes.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1199       +/-   ##
===========================================
+ Coverage   80.75%   91.22%   +10.46%     
===========================================
  Files          15       13        -2     
  Lines         977     1174      +197     
===========================================
+ Hits          789     1071      +282     
+ Misses        188      103       -85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efahl
Copy link
Contributor

efahl commented Feb 6, 2025

Yes, I'll see about adding the client code to LuCI.

As far as I can tell, that's the biggest missing piece in the LuCI app for cross-release upgrades, it doesn't do the package_changes processing. Do you have any other things that you'd like to see in it?

@aparcar aparcar merged commit 2bff208 into openwrt:main Feb 6, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants