phase1: allow to run webhooks

[aparcar]

This is especially nice to trigger Docker builds containing the latest containers.

[ynezz]

Can we make this future proof and allow more hooks from the start, thus handling it as branches/workers?

[aparcar]

Done with the reimplementation.

[aparcar]

@ynezz I tried a more generic approach. Sadly I don't have any test infra for now, maybe @f00b4r0 can have a look at this, too?

[f00b4r0]

@aparcar not much time right now, however I have a couple questions:

• wouldn't http://docs.buildbot.net/current/manual/configuration/reporters/github_status.html work here?
• extracting branch/target by splitting the builder name is definitely not robust and will be a problem if later we decide to change the naming pattern. These properties should be accessible directly from the build object. Maybe webhooks even supports Interpolate()?
  HTH

[aparcar]

• wouldn't http://docs.buildbot.net/current/manual/configuration/reporters/github_status.html work here?

From my understanding this is for the "checks" under a PR and not exactly what we want here.

Example:

• extracting branch/target by splitting the builder name is definitely not robust and will be a problem if later we decide to change the naming pattern. These properties should be accessible directly from the build object. Maybe webhooks even supports Interpolate()?

Yes it's a bit awkward, do you mind pointing me to the properties I'm looking for?

[f00b4r0]

• extracting branch/target by splitting the builder name is definitely not robust and will be a problem if later we decide to change the naming pattern. These properties should be accessible directly from the build object. Maybe webhooks even supports Interpolate()?

Yes it's a bit awkward, do you mind pointing me to the properties I'm looking for?

The branch property is automatically set by buildbot and available from the build properties. Check e.g. https://buildbot.staging.openwrt.org/images/api/v2/builds/5989/properties or look on the web UI at any build for the "Build Properties" tab.

For target, I would simply add a builder property at the BuilderConfig() invocation here:
https://github.com/openwrt/buildbot/blob/280a07b9e6ba928ce5495dc19ed68d17e990396c/phase1/master.cfg#LL1278C3-L1278C164

e.g.:

c['builders'].append(BuilderConfig(name=bldrname, workernames=workerNames, factory=factory, tags=[brname,], properties={'target':target}, nextBuild=GetNextBuild, canStartBuild=canStartBuild))

You can then Interpolate() both properties in your Reporter.

HTH

[aparcar]

@f00b4r0 thanks, I reworked this PR based on your suggestions.

[aparcar]

In the meantime solved via this:

openwrt/docker#119 (comment)

[ynezz]

In the meantime solved via this:

Do I understand it correctly, that you don't want to proceed with this? Perhaps close it then? If you still want that included, then please make CI happy and thus we can merge/test/deploy this.

[aparcar]

I'm using rsync-xfer instead