phase1: raise priority of tag builds #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebase pls. |
Currently the buildmaster would only order tag builds within their own branch, meaning that if e.g. a higher priority branch has normal buildrequests (i.e. buildrequests comming from the AnyBranchScheduler), and a lower priority branch has "tag" buildrequests (i.e. from the Triggerable scheduler), the former builderequests would be served first, deferring the build of e.g. release tags. We want forced builds (release tag) to have maximum priority, regardless of branch priority. This commit attempts to solve this problem by leveraging the newly (as of buildbot 3.9.0) introduced "priority" scheduler parameter, by raising the Triggerable scheduler buildrequests priority, and then considering this higher priority in Builders' order. The net result is that Builders are now prioritized if they have pending higher priority buildrequest, still preserving the branch order. In other words, tag requests are front run while preserving branch order, meaning that if two branches have tag buildrequests, the higher priority branch is still served first. This requires buildbot 3.9.0 Signed-off-by: Thibaut VARÈNE <[email protected]>
Following discussion here: https://lists.openwrt.org/pipermail/openwrt-devel/2023-November/041769.html Signed-off-by: Thibaut VARÈNE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the buildmaster would only order tag builds within their own branch, meaning that if e.g. a higher priority branch has normal buildrequests (i.e. buildrequests comming from the AnyBranchScheduler), and a lower priority branch has "tag" buildrequests (i.e. from the Triggerable scheduler), the former builderequests would be served first, deferring the build of e.g. release tags.
We want forced builds (release tag) to have maximum priority, regardless of branch priority. This commit attempts to solve this problem by leveraging the newly (as of buildbot 3.9.0) introduced "priority" scheduler parameter, by raising the Triggerable scheduler buildrequests priority, and then considering this higher priority in Builders' order.
The net result is that Builders are now prioritized if they have pending higher priority buildrequest, still preserving the branch order. In other words, tag requests are front run while preserving branch order, meaning that if two branches have tag buildrequests, the higher priority branch is still served first.
This requires buildbot 3.9.0 so buildbot version is updated in the github workflow