Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not emit extra l4proto filter for helpers #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brada4
Copy link

@brada4 brada4 commented Nov 27, 2024

Do not emit unnecessary l4proto filter for helpers. No bytecode or readback changed.
There is something better waiting on top of this cleanup

Signed-off-by: Andris PE [email protected]

Do not emit unncessary l4proto filter for helpers. No bytecode or
readback changed.
There is something better waiting on top of this cleanup

Signed-off-by:
@brada4
Copy link
Author

brada4 commented Nov 27, 2024

@jow- please treat this quicker than usual

nft -c -d netlink -f - << EOF
table inet testing {
 chain old {
  meta l4proto tcp tcp dport 45
 }
 chain intent {
  meta l4proto tcp meta l4proto tcp th dport 45
 }
 chain new {
  tcp dport 45
 }
}
EOF

Evil intent of original is luckily squashed by nft cli.

@brada4
Copy link
Author

brada4 commented Nov 27, 2024

btw 3x if rule.helper sections are never accessed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant