-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaScript required for new apps #3378
Comments
I feel that it might be too strict to "require" JavaScript, but it might be "preferred". Personally I think that it does not make much difference in simple uci config apps without much calculation, logic or interactive status screens. The goal of JS is to move the CPU intensive processing to the client side, but many apps are rather simple and just used for basic uci config. |
Maybe I'm wrong but I though another advantage is to get rid of the lua
runtime and save some storage. Eventually lowering also the languages to
know for maintenance.
…On Sun Dec 1, 2019 at 2:59 AM, Hannu Nyman wrote:
I feel that it might be too strict to "require" JavaScript, but it might
be "preferred".
Personally I think that it does not make much difference in simple uci
config apps without much calculation, logic or interactive status
screens. The goal of JS is to move the CPU intensive processing to the
client side, but many apps are rather simple and just used for basic uci
config.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#3378 (comment)
|
Yes, the goal is to get rid of Lua completely for the LuCI base. |
Should we pin this? |
Where is migration guide to migrate from LUA-based to JS-based project? |
So the JavaScript apps run on the client-side in the browser vs Lua running via cgi-bin on the device, right? |
Unfortunately, I saw this too late and did not think on this, but I have merged this #4664 and it is written in lua. I can not revert this #4665 but I can request to write this #4664 in javascript or should I merge them? |
I can rewrite that in javascript, but can u maybe link to a good example? |
@PolynomialDivision @howard0su I'm afraid at this point the best documentation for migrating from Lua is the extensive LuCI JS documentation in combination with pull requests that did the migration in the past, there are multiple. @PolynomialDivision if you go through the process and find the time it would be great to share the experience and write it down in a document. |
Okay. :) Actually, I have to do document that since we have to rewrite all our luci apps for our community wireless network. Maybe @jonnytischbein will help me? ;) |
I would love to! :) |
I tried now rewrite the luci-app-babeld in javascript: |
I did a new rewrite of @PolynomialDivision pr #4791 with javascript dom. As @aparcar asked I would like to write down my process, but I'm not sure whether using the javascript dom instead of luci dom is okay ? Could you please give me some feedback ? |
I was looking to start converting my luci apps and have some questions, should I ask them here or create a new migration-related issue? |
@stangri please create single issues for that, I think @PolynomialDivision and @jonnytischbein are a tag team to tackle any upcoming questions. |
It would be very helpful if luci-app-splash were ported to JS as an example of an app which has both public and also non-public (authorization requited) content. @PolynomialDivision @jonnytischbein, could you imagine doing this? |
@pmelange in the next few weeks I won't be able to do that. But I am interested. :/ |
Is there any progress on this? |
Sorry for resurrecting the old topic.
|
I'm wondering if all new LuCI apps should be written in JavaScript and LUA is from now on considered legacy and not accepted for new apps anymore.
The documentation seem straight forward enough to easily convert existing LUA code to JS.
Please share your thoughts.
The text was updated successfully, but these errors were encountered: