Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-ser2net: new module supporting ser2net. #3541

Closed
wants to merge 1 commit into from
Closed

luci-app-ser2net: new module supporting ser2net. #3541

wants to merge 1 commit into from

Conversation

michyprima
Copy link
Contributor

Sparked and loosely inspired by #1480
This implements full support to the new uci config format for ser2net in luci.
Signed-off-by: Michele Primavera [email protected]

Sparked and loosely inspired by #1480
Signed-off-by: Michele Primavera <[email protected]>
@feckert feckert added the feature pull request adding a new feature label Jan 21, 2020
@feckert
Copy link
Member

feckert commented Jan 21, 2020

As discussed in #3378 I ask you to convert the implementation from LUA to Javascript? This shouldn't be too difficult as it is only use uci handling. There are already some application converted.
https://github.com/openwrt/luci/tree/master/applications/luci-app-yggdrasil/htdocs/luci-static/resources/view/yggdrasil

@feckert feckert added the WIP pull request the author is still working on label Jan 21, 2020
@michyprima
Copy link
Contributor Author

@feckert Sorry, didn't see the pinned issue. I converted the app and it's working, the only thing I'm missing is how do I trigger /etc/init.d/ser2net restart after saving?

@jow-
Copy link
Contributor

jow- commented Jan 21, 2020

The ser2net init script is procd enabled as far as I can see, so changes to its uci configuration should result in a service restart automatically.

@michyprima
Copy link
Contributor Author

michyprima commented Jan 21, 2020

it does not.
If I do:

uci set ser2net.global.enabled='0' && uci commit

the process does not stop

@jow-
Copy link
Contributor

jow- commented Jan 21, 2020

You also need to call /sbin/reload_config afterwards or `ubus call service event '{ "type": "config.change", "data": { "package": "ser2net" } }' (which is what LuCI does on Save & Apply.

@jow-
Copy link
Contributor

jow- commented Jan 21, 2020

You also need to call /sbin/reload_config afterwards or ubus call service event '{ "type": "config.change", "data": { "package": "ser2net" } }' (which is what LuCI does on Save & Apply).

@michyprima
Copy link
Contributor Author

It is still not working, I believe the init.d script is incomplete but I can't figure out what it is missing

@michyprima michyprima closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature pull request adding a new feature WIP pull request the author is still working on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants