-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luci-mod-status: channel_analysis: detect 160 MHz capable AP #7367
base: master
Are you sure you want to change the base?
Conversation
Implement a workaround to detect an 160MHz capable AP. It was introduced in the mac80211 in 2016 with 802.11ac Wave 2. APs capable of 160 MHz are detected by the shift of central frequencies. More detailed description in the link [1]. Every AP I have seen presents support for 160 MHz in this way. [1] torvalds/linux@23665aa Fixes: openwrt#6262 Signed-off-by: Aleksander Jan Bajkowski <[email protected]>
These are my first lines of code in js, so any feedback welcome :D |
Everything looks good, actually. Although what and where is the 'newer interop workaround'? |
@knarrff I think you dabbled in this area also. Any thoughts? |
I found that the issue was once reported by the @hnyman. |
The workaround is described in the linked commit description:
|
So, your code is already 'adjusted' based on the workaround? |
BTW: does this code depend on fixes which are already in iwinfo/master? |
This code doesn't depend on other changes in iwinfo. As far as I've seen, both iwinfo and iw only display raw data from received IEs (802.11 Information Element). Are you asking about other endianness issues described in the linked issue? |
No - just whether it's just this PR and no other requirements. I tested it but it appears that all my neighbours use 80 MHz only so could not verify :p |
Could you please check this which is related? Other than that, how is it possible to do a channel scan with an AP in DFS? |
Likely a similar class of problem. Does iwinfo there report 2020 for dual
bonded channels?
|
Implement a workaround to detect an 160MHz capable AP. It was introduced in the mac80211 in 2016 with 802.11ac Wave 2. APs capable of 160 MHz are detected by the shift of central frequencies. More detailed description in the link [1]. Every AP I have seen presents support for 160 MHz this way.
[1] torvalds/linux@23665aa
Fixes: #6262
Signed-off-by: Aleksander Jan Bajkowski [email protected]
Signed-off-by: <[email protected]>
row (viagit commit --signoff
)<package name>: title
first line subject for packagesPKG_VERSION
in the Makefile