luci-app-wifischedule: Convert to JS #7371
Draft
+282
−283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luci-app-wifischedule: Convert to JS Signed-off-by: Ramon Van Gorkom [email protected]
|
So I think its 99% working, although I could not fully test it, seems the app on master has been updated compared to 23.05 branch and I have only devices on 23.05 currently running. The one thing that for sure does not work is the "Determine Modules Automatically" button. I am not sure how to get that working. It may be related to "ListValue.write(self, section, value_list)". I am not sure to convert that to js. The issue is that the button from a option wants to update the content of another option. Look at line 148. Does anybody have a suggestion? |
|
@newkit Maybe you can help/test the js version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
luci-app-wifischedule: Convert to JS
Signed-off-by: Ramon Van Gorkom [email protected]