Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luci-base: allow query params with POST. #7552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

luci-base: allow query params with POST. #7552

wants to merge 1 commit into from

Conversation

adelton
Copy link
Contributor

@adelton adelton commented Jan 10, 2025 •
edited
Loading

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <[email protected]> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: not tested
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes L.Requests.request doesn't allow query params with POST #3627
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: while not used by any of the applications shipped by OpenWrt, this completes the API for use-cases when both query parameters and POST body are needed.

@adelton adelton mentioned this pull request Jan 10, 2025
Open
@systemcrash
Copy link
Contributor

ping @jow- for this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adelton @systemcrash