Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netifyd: update to 5.0.61 #25359

Closed
wants to merge 1 commit into from
Closed

netifyd: update to 5.0.61 #25359

wants to merge 1 commit into from

Conversation

neheb
Copy link
Contributor

@neheb neheb commented Nov 14, 2024

Fix versioning to be compatible with apk.

Small cleanups.

Maintainer: @dsokoloski

Fix versioning to be compatible with apk.

Small cleanups.

Signed-off-by: Rosen Penev <[email protected]>
@dsokoloski
Copy link
Contributor

Thanks for updating to v5.x.x from v4.x.x.

I haven't done this myself yet because v5.x.x has a completely different plugin architecture compared to v4.x.x.

In version 5, there are no default output options. You can not read from a socket, or post to an HTTP server, or otherwise get data out of the Agent -- without the use of a plugin. All of that functionality has been separated into various plugins:

https://gitlab.com/netify.ai/public/netify-plugins

These are individual packages that have yet to be submitted to OpenWrt Packages for consideration.

In summary, anyone upgrading from v4.x.x to v5.x.x will be left with a broken install with all output functionality removed.

If you are interested in helping submit and clean-up the following plugins to OpenWrt Packages, we could start the process.

@hnyman
Copy link
Contributor

hnyman commented Nov 17, 2024

@neheb
Based on the answer from maintainer, would it be better to just adjust versioning for apk?

@neheb
Copy link
Contributor Author

neheb commented Nov 17, 2024

Yep

@hnyman
Copy link
Contributor

hnyman commented Nov 22, 2024

@neheb
Are you adjusting the PR? This is still breaking in the apk based main buildbot.

@neheb
Copy link
Contributor Author

neheb commented Nov 22, 2024

@hnyman you can handle it if you want.

@hnyman
Copy link
Contributor

hnyman commented Nov 23, 2024

I did that in #25436

@hnyman
Copy link
Contributor

hnyman commented Dec 6, 2024

I will close this, as based on the discussion above, the PR would still need lots of changes to the package logic, and neheb is likely not going to do them (as his main idea was the apk compatibility).

@hnyman hnyman closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants