Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop APK version checking #25488

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented Dec 4, 2024

APK is now the default, the SDK action will try to compile things and fails if the version doesn't fit.

APK is now the default, the SDK action will try to compile things and
fails if the version doesn't fit.

Signed-off-by: Paul Spooren <[email protected]>
@aparcar aparcar requested a review from robimarko December 4, 2024 11:18
@aparcar aparcar merged commit 57394d5 into openwrt:master Dec 4, 2024
11 of 13 checks passed
@aparcar aparcar deleted the ci-no-apk-check branch December 4, 2024 11:21
@hnyman
Copy link
Contributor

hnyman commented Dec 6, 2024

@aparcar
I suggest that we do the same for 24.10.
Apk is not coming there, and updates are mainly cherry-picks from master.

The PRs there are now failing CI for the same reason as master was: the third-party component that you used "Run peter-evans/create-or-update-comment@v2", is no longer available or something like that...
e.g. https://github.com/openwrt/packages/actions/runs/12192275978/job/34012630135?pr=25506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants