-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddns-scripts: Update dnspod.cn-v3 #25748
ddns-scripts: Update dnspod.cn-v3 #25748
Conversation
8517849
to
f45079b
Compare
c8eb9ab
to
8634180
Compare
Found some @feckert Should notify specific maintainers about this? $grep -rl 'retry_count' ./net/ddns-scripts/files/usr/lib/ddns | xargs grep -L 'retry_max_count'
./net/ddns-scripts/files/usr/lib/ddns/update_cloudflare_com_v4.sh
./net/ddns-scripts/files/usr/lib/ddns/update_dnspod_cn.sh
./net/ddns-scripts/files/usr/lib/ddns/update_godaddy_com_v1.sh
./net/ddns-scripts/files/usr/lib/ddns/update_luadns_v1.sh |
@FriesI23 nice catch. Thanks. |
8634180
to
bb714c4
Compare
Make separate commits √, but not sure if I need to use two PR for this. |
bb714c4
to
98d9702
Compare
Fine with me. Please also bump the PKG_RELEASE by one in each commit. |
98d9702
to
ade68c5
Compare
Fix signature expiration issue during retries. Signed-off-by: FriesI23 Qin <[email protected]>
Migrate retry_count to retry_max_count in the script to fix infinite retry loop. Signed-off-by: FriesI23 Qin <[email protected]>
ade68c5
to
dc3e360
Compare
Done but suspended for Long-Time queued CIs ;-( |
Thanks merged! |
Maintainer: FriesI23 Qin / @FriesI23
Compile tested: should be universal, Debian 12, OpenWrt 23.05.05
Run tested: i386_pentium4, vm on proxmox 8.3 using openwrt.sh, OpenWrt 23.05
Also tested: aarch64_generic, NanoPi R4S, OpenWrt 23.05.04
Description:
retry_count
toretry_max_count
in the script to fix infinite retry loop.This script copy from FriesI23/ddns-scripts_tencent_cloud which I maintain.