Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsftpd: fix bug related to option conf_file #25754

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

mhusaam
Copy link
Contributor

@mhusaam mhusaam commented Jan 15, 2025

  • I had wrongly used config_get_bool for the option, so fixed it
  • this also fixes the issue of /etc/init.d/vsftpd stop not working

Signed-off-by: Mohd Husaam Mehdi [email protected]

mhusaam referenced this pull request Jan 15, 2025
* update init script to validate and process UCI
* the option conf_file can be used to pass a conf file
  instead of using UCI

Signed-off-by: Mohd Husaam Mehdi <[email protected]>
@mhusaam mhusaam requested a review from schm0 January 16, 2025 06:21
@feckert
Copy link
Member

feckert commented Jan 21, 2025

@schm0 Thanks for testing.

@mhusaam can you please bump the PKG_RELEASE number by one in this commit. Then we are ready to merge.

* I had wrongly used config_get_bool for the option, so fixed it
* this also fixes the issue of /etc/init.d/vsftpd stop not working

Signed-off-by: Mohd Husaam Mehdi <[email protected]>
@mhusaam
Copy link
Contributor Author

mhusaam commented Jan 21, 2025

@feckert
Bumped the PKG_RELEASE version, I am sorry I always forget that.

@feckert feckert merged commit 473ea34 into openwrt:master Jan 21, 2025
12 checks passed
@feckert
Copy link
Member

feckert commented Jan 21, 2025

Thanks merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants