-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcproxy: fix igmpv3 and mld record type #1032
base: master
Are you sure you want to change the base?
Conversation
This patch fixes that if IGMPv3 Membership Report packet on the LAN interface with ALLOW_NEW_SOURCES record containing specific source is sent, then IGMPv3 Membership Report packet is received on the WAN interface and group record is ALLOW_NEW_SOURCES for the group with a matching source list. Signed-off-by: Rahul Thakur <[email protected]>
@sbyx ping |
Is this patch included in upstream? If not, are you willing to send it there? |
@BKPepe , thanks for your comment, I actually tried there first mcproxy/mcproxy#18 but got no response hence raised this as a patch here. |
I was thinking, if the upstream is dead for more than 7 years. What about rather dropping this package at all? Here are a few points which leads that removing is gonna be helpful:
Sometimes, it is just better to move on instead of relying on something which is obviously not working. |
+1 from me. |
I will create PR for removal shortly. |
This patch fixes that if IGMPv3 Membership Report packet on the LAN interface with ALLOW_NEW_SOURCES record containing specific source is sent, then IGMPv3 Membership Report packet is received on the WAN interface and group record is ALLOW_NEW_SOURCES for the group with a matching source list.