Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement No Response and pass metadata to resource handlers #28

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Implement No Response and pass metadata to resource handlers #28

wants to merge 10 commits into from

Conversation

malishav
Copy link
Contributor

@malishav malishav commented Mar 20, 2019 •
edited
Loading

This PR enhances the CoAP lib to:

  • Implement the No Response option as per RFC7967. No Response option enables the client to indicate that it is not interested in a particular class of responses. The PR implements the suppression of all responses only. A new functional test is added in the test suite to demonstrate the use of the new functionality.
  • Signal metadata to the handlers with information such as IP addresses and misc.

The PR resolves the following issues:

@malishav malishav force-pushed the develop_COAP-44 branch 2 times, most recently from f147a48 to 82b0766 Compare March 30, 2019 21:52
malishav added 9 commits April 1, 2019 17:20
@malishav
COAP-43. Implement No Response option with supress all responses value.
37617b9
@malishav
COAP-43. Rename the NoResponse option argument for clarity
e213c6a 
Use byte list to be consistent with other options.
@malishav
COAP-43. Add an exception for requests with NoResponse option.
3508246 
The NoResponsExpected exception is raised by the underlying lib when the
client sends a request with a NoResponse option included.
@malishav
COAP-43. Modify the state machine to support NoResponse requests.
43c896c 
A new state is added that is hit when a NoResponse request is sent.
Currently the implementation only supports NON messages.
@malishav
COAP-43. Add NoResponse functional test.
c1178dc
@malishav
COAP-43. Add supress all value as default.
ec41bb4
@malishav
COAP-44. Resource callbacks with metadata and metadata passing in tes…
29a5287 
…ting mode
@malishav
COAP-44. Enable external modules to pass socket class to use.
87cb8e6
@malishav
COAP-44. Fix possible mismatch due to different string encoding of IPv6.
a4d86cc
@malishav malishav changed the title Pass metadata to resource handlers Implement No Response and pass metadata to resource handlers Apr 1, 2019
@changtengfei
Copy link
Member

I got following error when running a simulation. Please test with the latest develop branch of firmware and openvisualizer.

16:53:31 INFO 2 [IEEE802154E] synchronized at slotOffset 0
ERROR could not call <bound method coapServer._receiveFromMesh of <openvisualizer.JRC.JRC.coapServer
object at 0x034F67F0>>, err=init() got an unexpected keyword argument 'receiveCallback'

@malishav
Copy link
Contributor Author

argh forgot that OV-7 has not been merged yet. let's park this for merge together with OV-7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malishav @changtengfei