Refactor process_message_3 to follow implementation guidelines #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malishav
changed the title
malishav
force-pushed
the
129-refactor-process_message_3-to-follow-implementation-guidelines
branch
from
bf9075b to
0513f02
Compare
geonnave
reviewed
Nov 6, 2023
| let ead_success = if let Some(ead_3) = ead_3 { | ||
| r_process_ead_3(ead_3).is_ok() | ||
| cred_i = if let Some(cred_i_expected) = cred_i_expected { | ||
| // 1. Does ID_CRED_X point to a stored authentication credential? YES |
There was a problem hiding this comment.
We could leave a pointer to Marco's diagram, just to make clear where these comments come from.
Suggestion: Comments tagged with a number refer to Marco Tiloca's implementation guidelines diagram (yet to be published).
| @@ -287,19 +289,86 @@ pub fn r_process_message_3( | |||
| let decoded_p3_res = decode_plaintext_3(&plaintext_3); | |||
|
|
|||
| if decoded_p3_res.is_ok() { | |||
| let (kid, mac_3, ead_3) = decoded_p3_res.unwrap(); | |||
| let (id_cred_i, mac_3, ead_3) = decoded_p3_res.unwrap(); | |||
There was a problem hiding this comment.
Just to leave this as a note, for now this will only work for the following cases:
- R receives KID and has the associated CRED_I locally stored
- R receives CRED_I and uses it
According to lake-authz, R (V) could also support receiving KID and calling W to resolve CRED_I. We could leave a TO-DO for that in the code.
malishav
force-pushed
the
129-refactor-process_message_3-to-follow-implementation-guidelines
branch
from
0513f02 to
0906fa0
Compare
|
@geonnave fstar generation seems to be triggered for this PR now and it fails. could you check if the command is OK? |
malishav
force-pushed
the
129-refactor-process_message_3-to-follow-implementation-guidelines
branch
from
0906fa0 to
2fbf6f7
Compare
malishav
deleted the
129-refactor-process_message_3-to-follow-implementation-guidelines
branch
geonnave
added
new feature
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
r_process_message_3routine to allow generic handling of EAD items and of credentials, as per draft-tiloca-lake-implem-cons.It also updated the
decode_plaintext_3routine to enable the credential to be passed in the message by value, instead only by reference.Closes #129