Move -crypto-trait in with -consts & related cleanups #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's one fewer crate to handle, and edhoc-consts is more an edhoc-common nowadays anyway.
chrysn
changed the title
|
This has turned up into a bit of a cleanup spree, all commits being documented individually. Please let me know if anything warrants better justification, I think they're all just straightforward. |
chrysn
force-pushed
the
one-less-crate
branch
from
aae290b to
25163a2
Compare
chrysn
force-pushed
the
one-less-crate
branch
from
25163a2 to
6b0cf29
Compare
Merged
|
Thanks for this PR! Looks good and fstar generation passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the crypto trait was introduced in #127, I tried to constrain it to the crypto/ directory. Seeing now that edhoc-consts is more and more becoming a pool of shared definitions, and keeping crates.io publication in mind, I think it's prudent to not have an extra crate, but let the crypto trait just be a module in edhoc-consts.
The refactor is marked as breaking because it removes a crate and makes a name unavailable; all affected crates are fixed by just importing the trait from somewhere else.
As bycatch now that I'm touching it, the second commit adds documentation to the trait.