Adding functions for message_4 #312

ElsaLopez133 · 2024-10-24T08:16:41Z

Adding trait to call the edhoc_exporter and edhoc_prk_update either when in state in message 3 or 4.
Adding functions to prepare, parse, and process message 4.
Corrected examples (coap and lakers-nrf52840).
Added tests.

geonnave

Congrats on your first PR, it looks very good!

Did a first very quick review round, I will let you have CI passing for the test matrix and then do a more detailed one.

.gitignore

examples/coap/src/bin/coapclient.rs

examples/coap/src/bin/coapserver.rs

lib/src/edhoc.rs

geonnave · 2024-10-24T13:08:36Z

Please also follow the project's convention for commit messages. We use a format loosely based on Conventional Commits. For example, you may change your first commit message to edhoc: add support for message_4. I recommend you take a look at git log and follow the style we use in the project.

geonnave

Reviewed the examples code, looks good, left a few nitpick comments.

examples/coap/src/bin/coapclient.rs

examples/coap/src/bin/coapserver.rs

examples/lakers-nrf52840/src/bin/initiator.rs

Adding functions for message_4 Adding trait to call the edhoc_exporter and edhoc_prk_update either when in state in message 3 or 4. Adding functions to prepare, parse, and process message 4

geonnave

Thanks for the update, my main comment is about prk_exporter. Let's discuss it offline.

lib/src/edhoc.rs

examples/coap/src/bin/coapserver-coaphandler.rs

lib/src/edhoc.rs

lib/src/lib.rs

Added test_handshake for 3 and 4 messages to derive prk_exporter in both cases Added a function completed_without_message4 for handshake with 3 messages Removed the trait for Done Fix minor mistakes

lib/src/lib.rs

remove test_handshake_message_4 in lib.rs

chrysn · 2024-11-04T13:54:38Z

Using this with aiocoap broke interoperability; before I dig further in: Is this supposed to be a breaking API change on the Python side, or merely an extension?

lakers-python/src/initiator.rs

Previously, a call to `.edhoc_exporter()` would happily have produced exports from the all-zero key material.

geonnave

Almost there @ElsaLopez133 ! Left a few more comments :)

lakers-python/src/initiator.rs

lakers-python/test/test_lakers.py

examples/coap/src/bin/coapserver.rs

lakers-c/src/initiator.rs

geonnave · 2024-11-25T09:46:55Z

@ElsaLopez133 congrats on finishing your first PR on lakers! And it was a big one! Merging now.

geonnave reviewed Oct 24, 2024

View reviewed changes

geonnave reviewed Oct 30, 2024

View reviewed changes

examples/coap/src/bin/coapclient.rs Outdated Show resolved Hide resolved

examples/coap/src/bin/coapserver.rs Outdated Show resolved Hide resolved

examples/lakers-nrf52840/src/bin/initiator.rs Show resolved Hide resolved

geonnave reviewed Nov 2, 2024

View reviewed changes

examples/lakers-nrf52840/src/bin/initiator.rs Outdated Show resolved Hide resolved

ElsaLopez133 added 4 commits November 2, 2024 18:57

edhoc:

153a97e

Adding functions for message_4 Adding trait to call the edhoc_exporter and edhoc_prk_update either when in state in message 3 or 4. Adding functions to prepare, parse, and process message 4

examples: fix errors, add cryptocell, add explanantions

16407d4

lib: fix test_authz

3190454

edhoc: correcting mutable references. gstar.

978bcd4

ElsaLopez133 force-pushed the message4_new branch from bb2d03b to 978bcd4 Compare November 2, 2024 17:58

example: uncomment psa memory buffer

0fac1f0

geonnave reviewed Nov 2, 2024

View reviewed changes

lib/src/edhoc.rs Outdated Show resolved Hide resolved

examples/coap/src/bin/coapserver-coaphandler.rs Outdated Show resolved Hide resolved

lib/src/edhoc.rs Outdated Show resolved Hide resolved

lib/src/edhoc.rs Outdated Show resolved Hide resolved

geonnave reviewed Nov 2, 2024

View reviewed changes

lib/src/lib.rs Outdated Show resolved Hide resolved

geonnave reviewed Nov 2, 2024

View reviewed changes

lib/src/lib.rs Outdated Show resolved Hide resolved

geonnave reviewed Nov 2, 2024

View reviewed changes

lib/src/lib.rs Outdated Show resolved Hide resolved

geonnave reviewed Nov 2, 2024

View reviewed changes

lib/src/lib.rs Outdated Show resolved Hide resolved

edhoc: new structure for message 4

9b23dea

Added test_handshake for 3 and 4 messages to derive prk_exporter in both cases Added a function completed_without_message4 for handshake with 3 messages Removed the trait for Done Fix minor mistakes

ElsaLopez133 force-pushed the message4_new branch from 457f378 to 9b23dea Compare November 2, 2024 19:38

geonnave reviewed Nov 3, 2024

View reviewed changes

lib/src/lib.rs Outdated Show resolved Hide resolved

python: fix python examples

c7b9cfe

remove test_handshake_message_4 in lib.rs

ElsaLopez133 force-pushed the message4_new branch from 9d21663 to 95b7958 Compare November 3, 2024 12:15

ElsaLopez133 added 2 commits November 3, 2024 13:18

lakers-c: fixing c wrapper for message_4

21e044b

examples: fix lakers-no_std

9dc6011

ElsaLopez133 force-pushed the message4_new branch from b2773c3 to 9dc6011 Compare November 3, 2024 12:23

chrysn reviewed Nov 4, 2024

View reviewed changes

lakers-python/src/initiator.rs Outdated Show resolved Hide resolved

chrysn mentioned this pull request Nov 4, 2024

python: Make safer to use #321

Merged

malishav and others added 4 commits November 5, 2024 12:18

example: remove git dependencies on embassy

993d4d2

example: improve nrf readme on multiple probes

0923a74

python: Make safer to use

d46cd51

Previously, a call to `.edhoc_exporter()` would happily have produced exports from the all-zero key material.

python: rebase to add chris commit. python-no-zero-keys

160e3b2

python: fix examples in python. Advanced state. Fix optional values

25e1206

ElsaLopez133 force-pushed the message4_new branch from 7f8d669 to 25e1206 Compare November 5, 2024 12:20

ElsaLopez133 and others added 3 commits November 5, 2024 13:22

Merge branch 'main' into message4_new

cc3ca98

python: correct style

9644815

lakers-no_std: update mutable references

815c2a4

ElsaLopez133 force-pushed the message4_new branch from e27c78d to 2fefa55 Compare November 19, 2024 15:04

shared: adding WaitM4 to cbindgen

628266e

ElsaLopez133 force-pushed the message4_new branch from 2fefa55 to 628266e Compare November 19, 2024 15:07

geonnave reviewed Nov 21, 2024

View reviewed changes

lakers-python/src/initiator.rs Outdated Show resolved Hide resolved

lakers-python/test/test_lakers.py Outdated Show resolved Hide resolved

examples/coap/src/bin/coapserver.rs Outdated Show resolved Hide resolved

lakers-c/src/initiator.rs Show resolved Hide resolved

ElsaLopez133 added 2 commits November 22, 2024 22:52

python: correct typo in function process_message_4

47c7216

python: adding message_4 in test_lakers.py

5b46303

geonnave merged commit 975010e into openwsn-berkeley:main Nov 25, 2024
37 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding functions for message_4 #312

Adding functions for message_4 #312

ElsaLopez133 commented Oct 24, 2024

geonnave left a comment

geonnave commented Oct 24, 2024

geonnave left a comment

geonnave left a comment

chrysn commented Nov 4, 2024

geonnave left a comment

geonnave commented Nov 25, 2024

Adding functions for message_4 #312

Adding functions for message_4 #312

Conversation

ElsaLopez133 commented Oct 24, 2024

geonnave left a comment

Choose a reason for hiding this comment

geonnave commented Oct 24, 2024

geonnave left a comment

Choose a reason for hiding this comment

geonnave left a comment

Choose a reason for hiding this comment

chrysn commented Nov 4, 2024

geonnave left a comment

Choose a reason for hiding this comment

geonnave commented Nov 25, 2024