Combine #335 and #337 #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto combine-337-335
|
Combining them led to fewer tests passing than #337 alone, abandoning this for the moment. (Not closing yet to keep access to retries easy.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bluntly combines PRs #335 and #337 -- not from any analysis of the issue #334 which both aim to solve, but merely based on the observation that there are different sets of tests that keep failing after applying them.
Should CI just pass on this, I propose @malishav merges malishav/rust-psa-crypto#1 (which is the essence of #337, and #337 becomes moot once that is merged), and then re-run #335 which should then pass -- but let's see what comes out of the tests.