Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Legacy) develop_FW-866 OpenRadio interface #504
base: develop
Are you sure you want to change the base?
(Legacy) develop_FW-866 OpenRadio interface #504
Changes from 32 commits
6ffee84
92a27e9
9035323
9999fe1
ff29667
eebd083
133dc1c
984444a
9273ca3
a6468d7
1669b80
999f50f
917665d
64006b5
0de94cb
185038e
ecc3bd2
56ed0cf
480f1dc
9226da2
6dda3e9
39a1bdc
f0d59e5
6bae185
75b7eb1
d2b9c40
0166d42
aa7237b
2464d80
f23a799
4882b35
c9f560e
e5fdab3
4e484f2
74ca322
48f3080
6ecca16
49d565f
a506320
6a8f446
5e6ca11
ba85ad8
c861218
5110952
5538db7
1a1926b
cdf2911
e5b34b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are 2 antennas, why these functions?!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really sure. My understanding is the they define which radio chip uses the 24ghz antenna
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, there are two antennas on the OpenMoteB. One antenna is 2.4 GHz only, the other one is 868 MHz only. And there are 3 radios in total, two at 2.4 GHz and one at 868 MHz. On the OpenMoteB schematic, I see U8 (bottom right), which looks like an RF switch. It switches the 2.4 GHz antenna between the cc2538 2.4 GHz radio port and the at86rf215 2.4 GHz radio port. PD3 and PD4 of the cc2538 look like the control signals of this RF switch. The functions discussed here activate these PD3 and PD4 signals. (see lines 104-111 of this file, and lines 75-76 of board_info.h)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments are always
//
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did my best fixing those now., I see this style used many board definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't care about anything than 3 settings, and 40ms timeslots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 10ms and 20ms are used in other board, should I definitely remove them? @changtengfei @TimothyClaeys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you make this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just replaced the board.c file with the one from the subghz project by Jonathan since I knew it was working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same