Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs_debug: Restore log size limit for userspace #16664

Merged
merged 1 commit into from
Oct 20, 2024
Merged

zfs_debug: Restore log size limit for userspace #16664

merged 1 commit into from
Oct 20, 2024

Conversation

amotin
Copy link
Member

@amotin amotin commented Oct 18, 2024

For some reason it was dropped when split from kernel, that made raidz_test to accumulate in RAM up to 100GB of logs we don't need.

Fixes #16492
Fixes #16566

How Has This Been Tested?

Manually run ./raidz_test -S -e -t 300 and observed its memory usage.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
zfs_debug: Restore log size limit for userspace
8d857b0 
For some reason it was dropped when split from kernel, that makes
raidz_test to accumulate in RAM up to 100GB of logs we don't need.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Fixes openzfs#16492
Fixes openzfs#16566
@amotin amotin requested a review from robn October 18, 2024 17:45
behlendorf
behlendorf approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that nicely explains why this only recently cropped up.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Oct 18, 2024
@robn
Copy link
Member

robn commented Oct 19, 2024

Ugh, yeah, fair enough. I don't think I removed this on purpose, more likely just didn't obviously see anything that needed it. Thanks!

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 20, 2024
@behlendorf behlendorf merged commit fba6a90 into openzfs:master Oct 20, 2024
19 of 20 checks passed
@amotin amotin deleted the debug branch October 21, 2024 13:22
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Oct 21, 2024
@amotin @behlendorf
zfs_debug: Restore log size limit for userspace
0a0168d 
For some reason it was dropped when split from kernel, that makes
raidz_test to accumulate in RAM up to 100GB of logs we don't need.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by:  Rob Norris <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes openzfs#16492
Closes openzfs#16566
Closes openzfs#16664
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Oct 21, 2024
@amotin @behlendorf
zfs_debug: Restore log size limit for userspace
ace2e17 
For some reason it was dropped when split from kernel, that makes
raidz_test to accumulate in RAM up to 100GB of logs we don't need.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by:  Rob Norris <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes openzfs#16492
Closes openzfs#16566
Closes openzfs#16664
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Jan 26, 2025
@amotin @lundman
zfs_debug: Restore log size limit for userspace
da13294 
For some reason it was dropped when split from kernel, that makes
raidz_test to accumulate in RAM up to 100GB of logs we don't need.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by:  Rob Norris <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes openzfs#16492
Closes openzfs#16566
Closes openzfs#16664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robn robn robn approved these changes

@behlendorf behlendorf behlendorf approved these changes

@ikozhukhov ikozhukhov ikozhukhov approved these changes

@mcmilk mcmilk mcmilk approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZTS: OOM in raidz_002_pos
5 participants
@amotin @robn @behlendorf @ikozhukhov @mcmilk