Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MathJax to properly format code #74

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Add MathJax to properly format code #74

merged 2 commits into from
Jan 21, 2025

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Jan 21, 2025

Fix #57

  • make codecov status only informational, since we do not expect high coverage on scrapers for now

Nota: MathJax configuration is inspired from configuration found at https://github.com/freeCodeCamp/freeCodeCamp/blob/main/client/src/utils/math-jax.ts but updated for MathJax 3. Not 100% confident it will work flawlessly on all cases, but seems fine so far.

Before After
Screenshot 2025-01-14 at 11 31 02 Screenshot 2025-01-20 at 21 26 49

@benoit74 benoit74 self-assigned this Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 43.02%. Comparing base (6286157) to head (3d56cc9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/fcc2zim/build.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   44.20%   43.02%   -1.19%     
==========================================
  Files           9        9              
  Lines         328      337       +9     
  Branches       41       43       +2     
==========================================
  Hits          145      145              
- Misses        182      191       +9     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review January 21, 2025 07:37
@benoit74 benoit74 requested a review from rgaudin January 21, 2025 07:38
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from add_pinia to main January 21, 2025 08:25
@benoit74 benoit74 merged commit b86e54d into main Jan 21, 2025
10 checks passed
@benoit74 benoit74 deleted the add_mathjax branch January 21, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly parse/present what looks like mathjax code
2 participants