Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter-out non-public videos and properly cleanup unsuccessful videos #363

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #362

@benoit74 benoit74 self-assigned this Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 1.50%. Comparing base (46c1d3c) to head (326187d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/youtube2zim/scraper.py 0.00% 4 Missing ⚠️
scraper/src/youtube2zim/youtube.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #363      +/-   ##
========================================
- Coverage   1.50%   1.50%   -0.01%     
========================================
  Files         11      11              
  Lines       1130    1132       +2     
  Branches     171     171              
========================================
  Hits          17      17              
- Misses      1113    1115       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 changed the title Filter-out non-public videos and delete only unsuccessful videos Filter-out non-public videos and properly cleanup unsuccessful videos Oct 14, 2024
@benoit74 benoit74 force-pushed the filter_private_vids branch from 224c168 to b707b90 Compare October 14, 2024 09:55
@benoit74 benoit74 marked this pull request as ready for review October 14, 2024 09:56
@benoit74 benoit74 requested a review from rgaudin October 14, 2024 09:56
@benoit74
Copy link
Collaborator Author

@rgaudin up :) (looks like it slipped your notifications ^^)

@benoit74 benoit74 force-pushed the filter_private_vids branch from b707b90 to 326187d Compare October 17, 2024 16:04
@benoit74 benoit74 merged commit f20ac6d into main Oct 17, 2024
10 checks passed
@benoit74 benoit74 deleted the filter_private_vids branch October 17, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scraper does not properly filter-out private videos
2 participants