Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the redirect articles coming from redirect file as front articles. #387

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

mgautierfr
Copy link
Collaborator

@mgautierfr mgautierfr commented Dec 4, 2023

This way, they are correctly title indexed.

Fixes #388

@mgautierfr
Copy link
Collaborator Author

Test are missing. But there is not existing test creating archive with a redirect file as input.
We can add it, but it will a bit longer than this quick fix.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8d143f4) 28.06% compared to head (8c3bff7) 28.00%.

Files Patch % Lines
src/zimwriterfs/zimcreatorfs.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   28.06%   28.00%   -0.07%     
==========================================
  Files          26       26              
  Lines        2576     2582       +6     
  Branches     1371     1373       +2     
==========================================
  Hits          723      723              
- Misses       1369     1375       +6     
  Partials      484      484              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgautierfr
Copy link
Collaborator Author

Agree with @kelson42 to merge as it is.

@mgautierfr mgautierfr merged commit 6875d84 into main Dec 4, 2023
12 of 13 checks passed
@mgautierfr mgautierfr deleted the zimwriterfs_redirect_as_front branch December 4, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Titles of Redirect Entries do not Show Up in Search Results
1 participant