-
Notifications
You must be signed in to change notification settings - Fork 38
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Create a cleaner temporary request object (#129)
* Create a cleaner temporary request object Using `Rails.application.routes.router.recognize` is not safe as it updates the passed argument, which is request in our case. Specifically it updates `rails_req.script_name` from `""` to `"/"` which makes `request.path` to have double slash in the beginning. To solve this issue it has been created a temporary clean request object which will be disposed later. See also: https://github.com/openzipkin/zipkin-ruby/pull/122/files (PR that has the same line before). * Improve syntax. Bump version. Update changelog.
- Loading branch information
1 parent
7c50494
commit d92d521
Showing
3 changed files
with
9 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module ZipkinTracer | ||
VERSION = '0.29.0'.freeze | ||
VERSION = '0.29.1'.freeze | ||
end |