-
Notifications
You must be signed in to change notification settings - Fork 50
🌱 bump k8s, helm-operator-plugins, of/operator-registry, and of/api #794
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 26.32% 26.29% -0.04%
==========================================
Files 9 9
Lines 809 810 +1
==========================================
Hits 213 213
- Misses 550 551 +1
Partials 46 46 ☔ View full report in Codecov by Sentry. |
Fixes #799 |
Signed-off-by: Joe Lanford <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the go-apidiff failure this LGTM. If that is expected then 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question regarding controller-gen bump.
Rest looks good to me, /lgtm from my end
@@ -12,7 +12,7 @@ BINGO="${GOBIN}/bingo-v0.8.0" | |||
|
|||
CONTROLLER_GEN="${GOBIN}/controller-gen-v0.12.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to bump this to 0.13.0: https://github.com/kubernetes-sigs/controller-tools/blob/v0.13.0/go.mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do this in a follow-up. Thanks for pointing it out!
9e67628
No description provided.