Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

🌱 bump k8s, helm-operator-plugins, of/operator-registry, and of/api #794

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

joelanford
Copy link
Member

No description provided.

@joelanford joelanford requested a review from a team as a code owner January 12, 2024 14:53
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a990f15) 26.32% compared to head (baea2cc) 26.29%.

Files Patch % Lines
...l/controllers/bundledeployment/bundledeployment.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   26.32%   26.29%   -0.04%     
==========================================
  Files           9        9              
  Lines         809      810       +1     
==========================================
  Hits          213      213              
- Misses        550      551       +1     
  Partials       46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go.mod Show resolved Hide resolved
@joelanford
Copy link
Member Author

Fixes #799

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2024
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the go-apidiff failure this LGTM. If that is expected then 👍

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question regarding controller-gen bump.
Rest looks good to me, /lgtm from my end

@@ -12,7 +12,7 @@ BINGO="${GOBIN}/bingo-v0.8.0"

CONTROLLER_GEN="${GOBIN}/controller-gen-v0.12.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this in a follow-up. Thanks for pointing it out!

@joelanford joelanford added this pull request to the merge queue Jan 17, 2024
Merged via the queue into operator-framework:main with commit 9e67628 Jan 17, 2024
8 of 11 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants