-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#55163] Build project-list sharing modal #15971
[#55163] Build project-list sharing modal #15971
Conversation
When we add #15983 here, the modal already works in a super rough capacity |
38c8adb
to
6dafc14
Compare
Rebased onto #15983 in order to get the fixes on there over on this branch |
Current modal rendering state Known issues:
Screen.Recording.2024-06-26.at.21.54.28.mov |
219598e
to
fef400e
Compare
#15983 has been merged and the |
Boilerplate to trigger a dialog component in the Projects index page header section.
5fb4649
to
48a3aec
Compare
This was marked as invalid YAML in my editor - Zed
Formatted by Zed editor's autocorrect feature
…to large when opened inside a dialog
…they do not span the whole width of the dialog they are rendered in
This is actually an issue of Primer itself where the automatic width calulation of ActionMenus inside Dialogs do not work, see primer/view_components#2926. As a wrokaround for now, we have to enforce the width of the ActionMenu manually. Unfortnately, we thus have to accept that the width is not always ideal. |
dbc0580
to
637ae9f
Compare
637ae9f
to
a7403fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice job @aaron-contreras and @klaustopher , just 2 minor things. Feel free to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nitpicks, though no specs added
Thanks Ivan! Co-authored-by: Ivan Kuchin <[email protected]>
* We use `mb: 3` to preserve the spacing off the modal header as we do in the share modal.
Thanks Ivan! Co-authored-by: Ivan Kuchin <[email protected]>
Thanks Ivan! Co-authored-by: Ivan Kuchin <[email protected]>
Co-authored-by: Ivan Kuchin <[email protected]>
ToDo List
ProjectQuery
as a shareable resourceProjectQuery
ShareDialog
that will be added as an async dialog via TurboSharingStrategy
pattern that wraps all of the content of the methodssharing_contract_scope
,available_roles
and potentially more to not end up with big case statements in theSharesController
as suggested by @ulferts in Generalize sharing modal #15899 (comment)share_work_packages
permission, we probably need to remove all permission checks from the shares controller and then handle permission checking with themanageable?
method in the strategy and contracts.can_save?
,can_rename?
checks for the project query index header component need to be changed to use thevisbile?
andeditable?
methods on the Query (@klaustopher)Currently identified problems
ActionMenu
Primer component uses an overlay to render its menu item list which ends up causing the container to span the entire width of the dialog for some reasonDocumentation TODOs
ShareDialogComponent
to Lookbookkeep-open-on-submit
(dccbdca) functionality to https://qa.openproject-edge.com/lookbook/pages/patterns/dialogsSee: https://community.openproject.org/work_packages/55163