[#60359] Update FeedbackDialog slot names #17568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
myabc
force-pushed
the
feature/60359-update-feedback_dialog-component-slots
branch
from
b43579a to
cc9db8f
Compare
HDinger
reviewed
Jan 13, 2025
myabc
force-pushed
the
feature/60359-update-feedback_dialog-component-slots
branch
from
cc9db8f to
823788e
Compare
FeedbackDialog slot names have been updated to be consistent with the DangerConfirmationDialog. https://community.openproject.org/work_packages/60359
myabc
force-pushed
the
feature/60359-update-feedback_dialog-component-slots
branch
from
823788e to
038071d
Compare
HDinger
approved these changes
Jan 13, 2025
HDinger
deleted the
feature/60359-update-feedback_dialog-component-slots
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/60359
What are you trying to accomplish?
Bumps Primer to 0.52.
FeedbackDialog slot names have been updated to be consistent with the DangerConfirmationDialog.
Upstream PR here: opf/primer_view_components#219
Renames the
additional_content slottoadditional_detailsto make Feedback Dialog consistent with the newly introduced Danger Confirmation Dialog.ViewComponent defines a
with_SLOT_NAME_contentmethod for given slots. Using additional_content as a slot name results in awith_additonal_content_contentmethod being generated - this makes for a poor API for component users.Screenshots
End users should not see any visual changes.
What approach did you choose and why?
Merge checklist