Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed width to max-width for text field style #54

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

apfohl
Copy link

@apfohl apfohl commented Nov 22, 2023

This PR changes the width CSS attribute of text input wraps to max-width to support a wider experience for smaller mobile views.

Copy link

changeset-bot bot commented Nov 22, 2023

🦋 Changeset detected

Latest commit: 6879136

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@apfohl
Copy link
Author

apfohl commented Nov 22, 2023

The failing check is due to upstream changes. As discussed with @HDinger we will merge it regardless of this check.

@HDinger HDinger merged commit 6ff6fbf into main Nov 22, 2023
28 of 29 checks passed
@HDinger HDinger deleted the textfield-max-width branch November 22, 2023 10:23
@openprojectci openprojectci mentioned this pull request Nov 22, 2023
Copy link
Member

@akabiru akabiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speedy fix! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants