Allow setting an id attribute on the BorderBox's ul element
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to perform turbo stream append and prepend actions on a `BorderBox` component, we need a way to specify a target via an `id` (or some unique CSS selector). We can't guarantee there is a unique selector for the specific BorderBox's `ul` element we want to append to without an id. This commit allows providing the `id` that will be rendered in the `BorderBox`'s ul element via the `list_id` system argument. A system argument has been added to the "Playground" preview for the `BorderBox`.
🦋 Changeset detectedLatest commit: 29a18c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aaron-contreras
force-pushed
the
housekeeping/allow-id-as-list-argument-on-border-boxes
branch
from
e8fef1a to
7e1ca2b
Compare
HDinger
force-pushed
the
housekeeping/allow-id-as-list-argument-on-border-boxes
branch
from
51d251f to
29a18c9
Compare
HDinger
deleted the
housekeeping/allow-id-as-list-argument-on-border-boxes
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
In order to perform turbo stream append and prepend actions on a
BorderBoxcomponent, we need a way to specify a target via anid(or some unique CSS selector). We can't guarantee there is a unique selector for the specific BorderBox'sulelement we want to append to without an id.This commit allows providing the
idthat will be rendered in theBorderBox's ul element via thelist_idsystem argument.A system argument has been added to the "Playground" preview for the
BorderBox.Screenshots
Before
After
Integration
No
List the issues that this change affects.
https://community.openproject.org/wp/51277
Merge checklist