Zen mode button component #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4ee4c9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
HDinger
force-pushed
the
zen-mode-button-component
branch
from
d5e2933 to
4bd294b
Compare
HDinger
force-pushed
the
zen-mode-button-component
branch
2 times, most recently
from
e9b74fd to
e845815
Compare
HDinger
approved these changes
Apr 4, 2024
HDinger
force-pushed
the
zen-mode-button-component
branch
from
e845815 to
4ee4c9a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
We want to create a global button component to be used for zen mode. When you click on this button, if the screen is in normal mode, it will turn to a full-screen mode. If it is in full-screen mode and you click on the button again, it will be in normal mode again.
Screenshots
Screenshot 2024-01-24 at 13 33 52
List the issues that this change affects.
Risk Assessment
What approach did you choose and why?
I render a Primer IconButton component for implementing this component and used Catalyst controller to handle click event of button.
Merge checklist