Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ansible scripts to install RHEL Auto Install OS on Dell servers #90

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Sakethanne
Copy link
Contributor

Added ansible scripts to install Ubuntu Auto Install OS on Dell servers

@Sakethanne Sakethanne requested a review from a team as a code owner December 4, 2024 02:01
ansible/install_os.yml Outdated Show resolved Hide resolved
ansible/install_os.yml Outdated Show resolved Hide resolved
ansible/install_os.yml Outdated Show resolved Hide resolved
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline

@Sakethanne Sakethanne force-pushed the install-os branch 2 times, most recently from d630cd8 to 80e490c Compare December 5, 2024 23:36
@Sakethanne
Copy link
Contributor Author

Fixed the scripts as per the all the suggestions

ansible/dell_os_install.yml Outdated Show resolved Hide resolved
ansible/install_os.yml Outdated Show resolved Hide resolved
# SPDX-License-Identifier: Apache-2.0
---
- name: Run OS installation on servers
hosts: hostbmcs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just put here dh1bm,dh4bmc ?
and avoid all switch cases later in the code ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified the hosts as well to dh1bmc and dh4bmc

ansible/install_os.yml Outdated Show resolved Hide resolved
tasks:
- name: Find the URL for the DellOSDeploymentService
when: inventory_hostname in ['dh1bmc', 'dh4bmc']
ansible.builtin.uri:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to find url every time ? Isn’t it fixed for dell ? Show me what this returns…

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to simplify, if this is fixed URL, just hard code it, no need to discover it, too complex

ansible/install_os.yml Outdated Show resolved Hide resolved
protocol: http
hostname: "{{ hostvars['mgmt']['ansible_host'] }}"
iso_path: ""
iso_name: "{{ ubuntu_iso }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
iso_name: "{{ ubuntu_iso }}"
iso_name: "ubuntu-22.04-autoinstall.iso"

Comment on lines 8 to 26
idrac_osd_command_allowable_values:
- "BootToNetworkISO"
- "GetAttachStatus"
- "DetachISOImage"
idrac_osd_command_default: "GetAttachStatus"
get_attach_status_code:
drivers_attach_status:
"0": "NotAttached"
"1": "Attached"
iso_attach_status:
"0": "NotAttached"
"1": "Attached"
idrac_https_port: 443
expose_duration: 1080
command: "{{ idrac_osd_command_default }}"
validate_certs: false
force_basic_auth: true
idrac_user: "root"
ubuntu_iso: ubuntu-22.04-autoinstall.iso
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all those vars, where do you use them?

@glimchb glimchb merged commit 7d1a2cb into opiproject:main Dec 9, 2024
10 of 11 checks passed
@glimchb glimchb changed the title Added ansible scripts to install Ubuntu Auto Install OS on Dell servers Added ansible scripts to install RHEL Auto Install OS on Dell servers Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants