Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Capslock Logic #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Capslock Logic #5

wants to merge 1 commit into from

Conversation

prafulbbandre
Copy link

Added Capslock logic.

@prafulbbandre prafulbbandre changed the title Update keyboard.js Added Capslock Logic Nov 1, 2023
@seanlip
Copy link
Member

seanlip commented Nov 2, 2023

Can you show proof of correctness?

Also I think you need to build guppy too -- see PRs made to the original guppy repo, they sometimes modify the js file.

seanlip
seanlip requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Also putting a review hold)

@HardikGoyal2003 HardikGoyal2003 mentioned this pull request Feb 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@prafulbbandre prafulbbandre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prafulbbandre @seanlip