Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of issue #210: Add info to the wiki about how to find the commit which caused an issue. #240

Merged
merged 9 commits into from
Jan 19, 2024

Conversation

satvshr
Copy link
Contributor

@satvshr satvshr commented Jan 14, 2024

Added my page to the sidebar of the wiki.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satvshr Please follow the PR guidelines -- make sure your title follows the usual instructions, and that the description is populated. Otherwise your PRs cannot be reviewed and will likely be closed for not following guidelines.

@satvshr satvshr changed the title Issue #210 continued Fix issue #210: Add info to the wiki about how to find the commit which caused an issue. Jan 16, 2024
@satvshr satvshr changed the title Fix issue #210: Add info to the wiki about how to find the commit which caused an issue. Fix part of issue #210: Add info to the wiki about how to find the commit which caused an issue. Jan 16, 2024
@satvshr
Copy link
Contributor Author

satvshr commented Jan 16, 2024

@seanlip kindly check it out, also could you tell me if my work here counts as a solved issue because I want to apply for the "member" role which I remember requires 2 completed issues.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should only add the new page to the wiki. Why does it contain all the other stuff? Please check your Files Changed tab and ensure that it contains only what is required.

also could you tell me if my work oppia/oppia#19297 counts as a solved issue because I want to apply for the "member" role which I remember requires 2 completed issues.

No, because the issue isn't solved/resolved yet. In any case, I think it is still a good idea for you to attempt other issues in order to gain familiarity with the codebase.

@satvshr
Copy link
Contributor Author

satvshr commented Jan 18, 2024

This PR should only add the new page to the wiki. Why does it contain all the other stuff? Please check your Files Changed tab and ensure that it contains only what is required.

It is doing exactly that sean, its adding the link to my page to debugging.md, adding the images required to assets, and adding the link to my page to sidebar

@seanlip
Copy link
Member

seanlip commented Jan 18, 2024

@satvshr The Files Changed tab is supposed to show a diff with the current codebase. The current codebase already has the images you mentioned, so something seems to be wrong with this PR. Please figure out what that is and fix it. https://github.com/oppia/oppia-web-developer-docs/tree/develop/images/findCommitWhichIntroducedBug

@seanlip
Copy link
Member

seanlip commented Jan 18, 2024

P.S. I suspect it might be because your remote repo is not up-to-date with develop, but I am not sure: https://github.com/satvshr/oppia-web-developer-docs/tree/satvshr

@satvshr
Copy link
Contributor Author

satvshr commented Jan 18, 2024

P.S. I suspect it might be because your remote repo is not up-to-date with develop, but I am not sure: https://github.com/satvshr/oppia-web-developer-docs/tree/satvshr

That was it.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@seanlip seanlip merged commit 1a6389a into oppia:develop Jan 19, 2024
3 checks passed
@satvshr satvshr deleted the satvshr branch January 21, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants