Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit tutorials #432

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Audit tutorials #432

merged 7 commits into from
Jan 13, 2025

Conversation

Ash-2k3
Copy link
Member

@Ash-2k3 Ash-2k3 commented Jan 9, 2025

Fixed the format/content of the live tutorials + fixed a broken sidebar link

@Ash-2k3 Ash-2k3 marked this pull request as ready for review January 9, 2025 17:20
@Ash-2k3
Copy link
Member Author

Ash-2k3 commented Jan 9, 2025

@seanlip PTAL at this PR, Thanks

cc @U8NWXD for info.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ash-2k3, thanks for proofreading, this looks much better! LGTM, just a small note.

One question -- did you want to also "hide" the answers to questions under a dropdown? Or will that be a separate PR? (If the latter, would it be possible to file an issue to track it and try to clean it up soonish? Please link to the issue in your reply to this thread.)

Thanks!

@@ -14,10 +25,10 @@ The UX writing team has filed a request on GitHub asking to update the text on t

## Procedure

<i>The following steps illustrate how a developer might tackle this issue. Try following this tutorial step-by-step on your local machine! This will give you a better sense of how to tackle other similar issues in the codebase.
*The following steps illustrate how a developer might tackle this issue. Try following this tutorial step-by-step on your local machine! This will give you a better sense of how to tackle other similar issues in the codebase.*

**Important:**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to use the "IMPORTANT" markdown syntax here, perhaps? https://github.com/orgs/community/discussions/16925

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. (Also we are currently using the Important markdown for practise questions)

@seanlip seanlip assigned Ash-2k3 and unassigned seanlip Jan 10, 2025
@Ash-2k3
Copy link
Member Author

Ash-2k3 commented Jan 13, 2025

Filed an issue for hiding the answers. -#433

@Ash-2k3
Copy link
Member Author

Ash-2k3 commented Jan 13, 2025

Thanks @seanlip, I have filed an issue -#433 for hiding the answers.

@Ash-2k3 Ash-2k3 assigned seanlip and unassigned Ash-2k3 Jan 13, 2025
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@seanlip seanlip merged commit 8c491ef into oppia:develop Jan 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants