Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

333:Added 'requiresAdminCheck' to generateComment for Server Admin Notifications #343

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

333:Added 'requiresAdminCheck' to generateComment for Server Admin Notifications #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
824b172
Updated the PULL-REQUEST-TEMPLATE.md file,this helps the contributor …
Jan 28, 2025
8cd4105
Updated the PULL-REQUEST-TEMPLATE.md file,this helps the contributor …
Jan 28, 2025
a94bc75
Updated the checkPullRequestTemplate.js and PULL_REQUEST_TEMPLATE.md
Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@
- [ ] I have successfully deployed my own instance of Oppiabot.
- You can find instructions for doing this [here](https://github.com/oppia/oppiabot/wiki/Deploying-your-own-instance-of-the-oppiabot).
- [ ] I have manually tested all the changes made in this PR following the [manual tests matrix](https://github.com/oppia/oppiabot/wiki/Manual-Tests-Matrix).
- [ ] while making a pull request,if you have made some changes that requires server admin's check,instead of connecting directly with the server admin,add [SERVER ADMIN CHECK] in your PR description,this will automatically notify the server admins.
5 changes: 5 additions & 0 deletions lib/checkPullRequestTemplate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,11 @@ const generateComment = (pullRequest) => {
count += 1;
}

const requiresAdminCheck = pullRequest.body.includes('[SERVER ADMIN CHECK]')
if(requiresAdminCheck){
commentBody += `\n@oppiabot/server-admins-team Please review this PR as it requires server admin check`
}

// If there is no reason to produce the message do not return anything.
if (count === 1) {
return;
Expand Down