Workaround for ontology crashing on parameterized test #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingweitian
changed the title
xingweitian
reviewed
Mar 15, 2021
| @@ -93,6 +95,19 @@ protected void finish( | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * This copies the same overriding in OntologyInferenceAnnotatedTypeFactory, just to walk around | |||
| @@ -93,6 +95,19 @@ protected void finish( | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * This copies the same overriding in OntologyInferenceAnnotatedTypeFactory, just to walk around | |||
| * the crash happening in CFI continious integration, by setting default qualifier for type | |||
|
Identical to #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding default qualifier to work around crash in checker-framework-inference CI, for PRs like opprop/checker-framework-inference#249, opprop/checker-framework-inference#295.
The newly-added test file
ParameterizedTypeTest.javais to ensure that the workaround works, otherwise the unit test will crash in this case.