Remove implicit bottom checks #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcai1
commented
Mar 25, 2022
| @@ -79,25 +75,10 @@ public Void visitArray(AnnotatedTypeMirror.AnnotatedArrayType type, Tree tree) { | |||
| return super.visitArray(type, tree); | |||
| } | |||
|
|
|||
| @Override | |||
| public Void visitPrimitive(AnnotatedTypeMirror.AnnotatedPrimitiveType type, Tree tree) { | |||
| if (checkTopLevelDeclaredOrPrimitiveType) { | |||
There was a problem hiding this comment.
check if inference validator has the proper logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes introduced in opprop/checker-framework#207 and opprop/checker-framework-inference#394, we are able to remove all implicit bottom checks and use the underlying CF implementation instead. This PR also adds
@UpperBoundForwith proper definition to@Bottomin this type system.