Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: plugin.diff.file|type -> plugin.detectChanges #3175

Merged
merged 9 commits into from
Oct 17, 2024
Merged

refactor: plugin.diff.file|type -> plugin.detectChanges #3175

merged 9 commits into from
Oct 17, 2024

Conversation

samuelstroschein
Copy link
Member

  • simpler API
  • no redundant reporting of before and after

closes opral/lix-sdk#40

@samuelstroschein
refactor: plugin.diff.file|type -> plugin.detectChanges
7916d9b 
- simpler API
- no redundant reporting of before and after

closes opral/lix-sdk#40
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f375f42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

samuelstroschein
samuelstroschein commented Oct 16, 2024
View reviewed changes
lix/packages/sdk/src/plugin.ts
key: string;
glob: string;
glob?: string;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making glob optional because it's only used for plugin.detectChanges.

samuelstroschein
samuelstroschein commented Oct 16, 2024
View reviewed changes
lix/packages/sdk/src/resolve-conflict/resolve-conflict-with-new-change.test.ts
@@ -137,15 +133,11 @@ test("resolving a conflict should throw if the to be resolved with change is not

const mockPlugin: LixPlugin = {
key: "plugin1",
glob: "*",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing all redundant properties that are not tested.

@samuelstroschein
Copy link
Member Author

@martin-lysk straightforward change after our sync. no explicit review request. if you find something lmk

@samuelstroschein samuelstroschein mentioned this pull request Oct 16, 2024
Merged
@samuelstroschein
Copy link
Member Author

@martin-lysk if you reviewed and merges this, go ahead and merge #3177 too which builds on this PR

martin-lysk
martin-lysk reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@martin-lysk martin-lysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got to review some changes in the tests but here is the WIP review

lix/packages/sdk/src/file-handlers.ts Outdated Show resolved Hide resolved
lix/packages/sdk/src/file-handlers.ts Outdated Show resolved Hide resolved
lix/packages/sdk/src/file-handlers.ts Outdated Show resolved Hide resolved
lix/packages/sdk/src/file-handlers.ts Outdated Show resolved Hide resolved
@samuelstroschein samuelstroschein merged commit 0b4eb14 into lix-integration Oct 17, 2024
2 checks passed
@samuelstroschein samuelstroschein deleted the lixdk-107-plugindifffiletype-plugindetectchanges branch October 17, 2024 08:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@martin-lysk martin-lysk martin-lysk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelstroschein @martin-lysk