Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Prefect to 3.1.13 #5518

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Upgrade Prefect to 3.1.13 #5518

merged 6 commits into from
Jan 23, 2025

Conversation

dgarros
Copy link
Collaborator

@dgarros dgarros commented Jan 19, 2025

This PR is trying to upgrade Prefect to 3.1.13 because we need it for the event management epic as part of 1.2

Prefect made a lot of progress around Typing in 3.1.x but there are still a few issues reported by Mypy.
I opened some issues on prefect github project to track them and I've disabled mypy for these issues for now

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Jan 19, 2025
Copy link

codspeed-hq bot commented Jan 19, 2025

CodSpeed Performance Report

Merging #5518 will not alter performance

Comparing dga-20250119-prefect-3.1.13 (ec01f33) with develop (c668965)

Summary

✅ 10 untouched benchmarks

@github-actions github-actions bot added group/ci Issue related to the CI pipeline and removed group/ci Issue related to the CI pipeline labels Jan 19, 2025
@fatih-acar fatih-acar force-pushed the dga-20250119-prefect-3.1.13 branch 2 times, most recently from 5faefe8 to 5cfba70 Compare January 20, 2025 17:49
@fatih-acar
Copy link
Contributor

Need to investigate slowness on Prefect startup, it actually takes more than 30 seconds to start Prefect when running with xdist (probably because the CI runner is overwhelmed)

Maybe related to PrefectHQ/prefect#16299

@tomukmatthews
Copy link

Need to investigate slowness on Prefect startup, it actually takes more than 30 seconds to start Prefect when running with xdist (probably because the CI runner is overwhelmed)

Maybe related to PrefectHQ/prefect#16299

I have the same problem. I would be cautious about the latest versions of Prefect, many of our data pipelines are experiencing significant flakiness and degredation at the moment due to the performance related issues of the event driven architecture (internally) of prefect since 3.x. Have you experienced anything like that outside of tests?

@fatih-acar fatih-acar force-pushed the dga-20250119-prefect-3.1.13 branch 2 times, most recently from 00f3de9 to 7fb484e Compare January 21, 2025 20:44
@fatih-acar
Copy link
Contributor

Need to investigate slowness on Prefect startup, it actually takes more than 30 seconds to start Prefect when running with xdist (probably because the CI runner is overwhelmed)
Maybe related to PrefectHQ/prefect#16299

I have the same problem. I would be cautious about the latest versions of Prefect, many of our data pipelines are experiencing significant flakiness and degredation at the moment due to the performance related issues of the event driven architecture (internally) of prefect since 3.x. Have you experienced anything like that outside of tests?

We started using Prefect since 3.0, so we can't tell for previous releases.
But there seems to be a small performance regression between 3.0 and 3.1 that makes our CI pipelines fail due to load on our runners that causes slow startup.
We observe startups taking between 20s to 30s, and sometimes reaching the default timeout value which is 30s.
Fixed that by increasing server_startup_timeout in prefect_test_harness to 60s.

dgarros and others added 4 commits January 22, 2025 10:05
In some cases, when the CI runner is overwhelmed, 0.1s may not be enough
to successfully send a message to rabbitmq. Increase it to 1 second to
be consistent with other tests.

Signed-off-by: Fatih Acar <[email protected]>
30 second may not be enough when using Prefect 3.1 which seems to add a
little overhead to 3.0. Prefect usually took 20s-25s to start and a
small load spike on the CI runner can fail the tests.

Signed-off-by: Fatih Acar <[email protected]>
This was previously enabled on git agents but got removed during the
transition to task workers.
Prefect 3.1 also adds instrumentation to workflow runs.

Signed-off-by: Fatih Acar <[email protected]>
@fatih-acar fatih-acar force-pushed the dga-20250119-prefect-3.1.13 branch from 527d418 to 42c9eb0 Compare January 22, 2025 09:05
This is a temporary fix until we use the Infrahub image to run prefect
server.

Signed-off-by: Fatih Acar <[email protected]>
@github-actions github-actions bot added the group/ci Issue related to the CI pipeline label Jan 22, 2025
@fatih-acar fatih-acar marked this pull request as ready for review January 22, 2025 11:28
@fatih-acar fatih-acar requested review from a team as code owners January 22, 2025 11:28
@fatih-acar
Copy link
Contributor

fatih-acar commented Jan 22, 2025

Hardcoded versions in CI is not the best way to fix this.
I will work on using our own image to run prefect-server in another PR.

@fatih-acar
Copy link
Contributor

fatih-acar commented Jan 22, 2025

Still need to check the cache key error showing in the server logs
And fix the logger configuration

@dgarros
Copy link
Collaborator Author

dgarros commented Jan 23, 2025

Still need to check the cache key error showing in the server logs And fix the logger configuration

I pushed a fix for the cache key error, it was related to #5387
Let's merge this PR and we'll fix the logging issue in develop

@dgarros dgarros merged commit 900d523 into develop Jan 23, 2025
37 checks passed
@dgarros dgarros deleted the dga-20250119-prefect-3.1.13 branch January 23, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent) group/ci Issue related to the CI pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants