Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DMARC reports extraction #4

Merged
merged 4 commits into from
Jan 21, 2024
Merged

Fix DMARC reports extraction #4

merged 4 commits into from
Jan 21, 2024

Conversation

smortex
Copy link
Member

@smortex smortex commented Jan 20, 2024 •
edited
Loading

  • Add integration tests
  • Fallback to the whole mail if it has no parts
  • Extract the actual filename of the attachment

@smortex smortex added the bug Something isn't working label Jan 20, 2024
@smortex
Add integration tests
2fac7de 
Integrate aruba to test the CLI behaviour end-to-end.
@smortex
Fallback to the whole mail if it has no parts
fe038c9 
Some reports are sent as an attachment to the message, but some message
only contain the report and are not multi-part.

When attempting to locate a report, if no attachement is found consider
the whole message as being the part we are interested in.
@smortex
Extract the actual filename of the attachment
aef1a44 
The Content-Disposition header include more that the filename.  This
filename is used to determine the file type (based on the extension),
but for DMARC reports we also need to extract the compressed file name
in the attached archive.
@smortex
Enable new rubocop checks
850aff0
@smortex smortex merged commit 79640c7 into main Jan 21, 2024
8 of 10 checks passed
@smortex smortex deleted the fix-dmarc-report-extraction branch January 21, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smortex