Skip to content

Commit

Permalink
Merge branch 'feature/#276-db-migration' of github.com:oqtopus-team/o…
Browse files Browse the repository at this point in the history
…qtopus-cloud into feature/#276-db-migration
  • Loading branch information
katsujukou committed Dec 27, 2024
2 parents 90b5357 + 6fd3984 commit 29f1b95
Show file tree
Hide file tree
Showing 15 changed files with 605 additions and 19 deletions.
19 changes: 17 additions & 2 deletions backend/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ SHELL := bash
.SHELLFLAGS := -eu -o pipefail -c
.DEFAULT_GOAL := help

.PHONY: generate-user-schema generate-provider-schema generate-all-schema run-user run-provider up down fmt lint test help
.PHONY: generate-user-schema generate-provider-schema generate-all-schema run-user run-provider up down mig-gen mig-up fmt lint test help

generate-user-schema: ## Generate user schema
@cd oas && $(MAKE) generate-user
Expand Down Expand Up @@ -68,6 +68,18 @@ up: ## Start the DB
down: ## Stop the DB
@docker compose down

mig-up: ## Run migration
@poetry run alembic upgrade head

mig-down: ## Rollback to specific revision
@poetry run alembic downgrade "$(REV)"

mig-gen: ## Generatet migration script
@poetry run alembic revision --autogenerate -m "$(ARG)"

# db-seed:
# @poetry run

fmt-common: ## Format common code
@poetry run ruff format oqtopus_cloud/common

Expand All @@ -77,7 +89,10 @@ fmt-user: ## Format user code
fmt-provider: ## Format provider code
@poetry run ruff format oqtopus_cloud/provider

fmt-all: fmt-common fmt-user fmt-provider ## Format all code
fmt-migration: ## Format migration script code
@poetry run ruff format alembic/versions

fmt-all: fmt-common fmt-user fmt-provider fmt-migration ## Format all code

lint-common: ## Run common linters
@poetry run ruff check oqtopus_cloud/common
Expand Down
116 changes: 116 additions & 0 deletions backend/alembic.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
# A generic, single database configuration.

[alembic]
# path to migration scripts
# Use forward slashes (/) also on windows to provide an os agnostic path
script_location = alembic

# template used to generate migration file names; The default value is %%(rev)s_%%(slug)s
# Uncomment the line below if you want the files to be prepended with date and time
# see https://alembic.sqlalchemy.org/en/latest/tutorial.html#editing-the-ini-file
# for all available tokens
# file_template = %%(year)d_%%(month).2d_%%(day).2d_%%(hour).2d%%(minute).2d-%%(rev)s_%%(slug)s
file_template = %%(year)d%%(month).2d%%(day).2d__%%(rev)s__%%(slug)s

# sys.path path, will be prepended to sys.path if present.
# defaults to the current working directory.
prepend_sys_path = .

# timezone to use when rendering the date within the migration file
# as well as the filename.
# If specified, requires the python>=3.9 or backports.zoneinfo library.
# Any required deps can installed by adding `alembic[tz]` to the pip requirements
# string value is passed to ZoneInfo()
# leave blank for localtime
# timezone =

# max length of characters to apply to the "slug" field
# truncate_slug_length = 40

# set to 'true' to run the environment during
# the 'revision' command, regardless of autogenerate
# revision_environment = false

# set to 'true' to allow .pyc and .pyo files without
# a source .py file to be detected as revisions in the
# versions/ directory
# sourceless = false

# version location specification; This defaults
# to alembic/versions. When using multiple version
# directories, initial revisions must be specified with --version-path.
# The path separator used here should be the separator specified by "version_path_separator" below.
# version_locations = %(here)s/bar:%(here)s/bat:alembic/versions

# version path separator; As mentioned above, this is the character used to split
# version_locations. The default within new alembic.ini files is "os", which uses os.pathsep.
# If this key is omitted entirely, it falls back to the legacy behavior of splitting on spaces and/or commas.
# Valid values for version_path_separator are:
#
# version_path_separator = :
# version_path_separator = ;
# version_path_separator = space
version_path_separator = os # Use os.pathsep. Default configuration used for new projects.

# set to 'true' to search source files recursively
# in each "version_locations" directory
# new in Alembic version 1.10
# recursive_version_locations = false

# the output encoding used when revision files
# are written from script.py.mako
# output_encoding = utf-8

sqlalchemy.url = mysql+pymysql://%(DB_USER)s:%(DB_PASS)s@%(DB_HOST)s:3306/%(DB_NAME)s

[post_write_hooks]
# post_write_hooks defines scripts or Python functions that are run
# on newly generated revision scripts. See the documentation for further
# detail and examples

# format using "black" - use the console_scripts runner, against the "black" entrypoint
# hooks = black
# black.type = console_scripts
# black.entrypoint = black
# black.options = -l 79 REVISION_SCRIPT_FILENAME

# lint with attempts to fix using "ruff" - use the exec runner, execute a binary
# hooks = ruff
# ruff.type = exec
# ruff.executable = %(here)s/.venv/bin/ruff
# ruff.options = --fix REVISION_SCRIPT_FILENAME

# Logging configuration
[loggers]
keys = root,sqlalchemy,alembic

[handlers]
keys = console

[formatters]
keys = generic

[logger_root]
level = WARN
handlers = console
qualname =

[logger_sqlalchemy]
level = WARN
handlers =
qualname = sqlalchemy.engine

[logger_alembic]
level = INFO
handlers =
qualname = alembic

[handler_console]
class = StreamHandler
args = (sys.stderr,)
level = NOTSET
formatter = generic

[formatter_generic]
format = %(levelname)-5.5s [%(name)s] %(message)s
datefmt = %H:%M:%S
1 change: 1 addition & 0 deletions backend/alembic/README
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Generic single-database configuration.
102 changes: 102 additions & 0 deletions backend/alembic/env.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
from logging.config import fileConfig
from os import environ

from alembic import context
from oqtopus_cloud.common.models import Base
from sqlalchemy import TypeDecorator, engine_from_config, pool

# this is the Alembic Config object, which provides
# access to the values within the .ini file in use.
config = context.config

# Interpret the config file for Python logging.
# This line sets up loggers basically.
if config.config_file_name is not None:
fileConfig(config.config_file_name)

# add your model's MetaData object here
# for 'autogenerate' support
# from myapp import mymodel
# target_metadata = mymodel.Base.metadata
target_metadata = Base.metadata

# other values from the config, defined by the needs of env.py,
# can be acquired:
# my_important_option = config.get_main_option("my_important_option")
# ... etc.


def render_item(type_, obj, autogen_context):
"""Apply custom rendering for selected items."""

if type_ == "type" and isinstance(obj, TypeDecorator):
return f"sa.{obj.impl!r}"

# default rendering for other objects
return False


def set_env_var(key: str):
val = environ.get(key)
if val is not None:
config.set_section_option("alembic", key, val)
else:
raise KeyError(f'Environment variable "{key}" is not set')


def run_migrations_offline() -> None:
"""Run migrations in 'offline' mode.
This configures the context with just a URL
and not an Engine, though an Engine is acceptable
here as well. By skipping the Engine creation
we don't even need a DBAPI to be available.
Calls to context.execute() here emit the given string to the
script output.
"""
url = config.get_main_option("sqlalchemy.url")
context.configure(
url=url,
target_metadata=target_metadata,
literal_binds=True,
dialect_opts={"paramstyle": "named"},
)

with context.begin_transaction():
context.run_migrations()


def run_migrations_online() -> None:
"""Run migrations in 'online' mode.
In this scenario we need to create an Engine
and associate a connection with the context.
"""
set_env_var("DB_HOST")
set_env_var("DB_USER")
set_env_var("DB_PASS")
set_env_var("DB_NAME")
connectable = engine_from_config(
config.get_section(config.config_ini_section, {}),
prefix="sqlalchemy.",
poolclass=pool.NullPool,
)

with connectable.connect() as connection:
context.configure(
connection=connection,
target_metadata=target_metadata,
render_item=render_item,
)

with context.begin_transaction():
context.run_migrations()


if context.is_offline_mode():
run_migrations_offline()
else:
run_migrations_online()
26 changes: 26 additions & 0 deletions backend/alembic/script.py.mako
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
"""${message}

Revision ID: ${up_revision}
Revises: ${down_revision | comma,n}
Create Date: ${create_date}

"""
from typing import Sequence, Union

from alembic import op
import sqlalchemy as sa
${imports if imports else ""}

# revision identifiers, used by Alembic.
revision: str = ${repr(up_revision)}
down_revision: Union[str, None] = ${repr(down_revision)}
branch_labels: Union[str, Sequence[str], None] = ${repr(branch_labels)}
depends_on: Union[str, Sequence[str], None] = ${repr(depends_on)}


def upgrade() -> None:
${upgrades if upgrades else "pass"}


def downgrade() -> None:
${downgrades if downgrades else "pass"}
45 changes: 45 additions & 0 deletions backend/alembic/versions/20240911__38a0365a40fd__create_devices.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
"""create devices
Revision ID: 38a0365a40fd
Revises:
Create Date: 2024-09-11 16:35:08.445166
"""

from typing import Sequence, Union

import sqlalchemy as sa
from alembic import op

# revision identifiers, used by Alembic.
revision: str = "38a0365a40fd"
down_revision: Union[str, None] = None
branch_labels: Union[str, Sequence[str], None] = None
depends_on: Union[str, Sequence[str], None] = None


def upgrade() -> None:
# ### commands auto generated by Alembic - please adjust! ###
op.create_table(
"devices",
sa.Column("id", sa.String(length=64), nullable=False),
sa.Column("device_type", sa.String(length=128), nullable=False),
sa.Column("availability", sa.Boolean(), nullable=False),
sa.Column("restart_at", sa.DateTime(), nullable=True),
sa.Column("pending_tasks", sa.Integer(), nullable=False),
sa.Column("n_qubits", sa.Integer(), nullable=False),
sa.Column("n_nodes", sa.Integer(), nullable=True),
sa.Column("basis_gates", sa.String(length=256), nullable=False),
sa.Column("instructions", sa.String(length=64), nullable=False),
sa.Column("calibration_data", sa.Text(), nullable=False),
sa.Column("calibrated_at", sa.DateTime(), nullable=False),
sa.Column("description", sa.String(length=128), nullable=False),
sa.PrimaryKeyConstraint("id"),
)
# ### end Alembic commands ###


def downgrade() -> None:
# ### commands auto generated by Alembic - please adjust! ###
op.drop_table("devices")
# ### end Alembic commands ###
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
"""alter_tasks_table
Revision ID: 9b835b4d8801
Revises: 38a0365a40fd
Create Date: 2024-09-12 17:11:57.962993
"""
from typing import Sequence, Union

from alembic import op
import sqlalchemy as sa
from sqlalchemy.dialects import mysql

# revision identifiers, used by Alembic.
revision: str = '9b835b4d8801'
down_revision: Union[str, None] = '38a0365a40fd'
branch_labels: Union[str, Sequence[str], None] = None
depends_on: Union[str, Sequence[str], None] = None


def upgrade() -> None:
# ### commands auto generated by Alembic - please adjust! ###
op.alter_column('devices', 'calibration_data',
existing_type=mysql.TEXT(collation='utf8mb4_unicode_ci'),
nullable=True)
op.alter_column('devices', 'calibrated_at',
existing_type=mysql.DATETIME(),
nullable=True)
# ### end Alembic commands ###


def downgrade() -> None:
# ### commands auto generated by Alembic - please adjust! ###
op.alter_column('devices', 'calibrated_at',
existing_type=mysql.DATETIME(),
nullable=False)
op.alter_column('devices', 'calibration_data',
existing_type=mysql.TEXT(collation='utf8mb4_unicode_ci'),
nullable=False)
# ### end Alembic commands ###
Loading

0 comments on commit 29f1b95

Please sign in to comment.