Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pagination get jobs #61

Merged
merged 14 commits into from
Dec 26, 2024
Merged

feat: add pagination get jobs #61

merged 14 commits into from
Dec 26, 2024

Conversation

shgokita
Copy link
Contributor

πŸ“ƒ Ticket

https://github.com/FujitsuResearch/QuantumCloudPlatform/issues/223
https://github.com/FujitsuResearch/QuantumCloudPlatform/issues/238

✍ Description

  • add query parameters to GET /jobs API (both user and provider) to suppress output
    • available fields, startTime, endTime, q, order parameters
  • add pagination function to user GET /jobs API
    • use fastapi-pagination library
    • add page and size query parameters
  • add some test cases for GET /jobs API

πŸ“Έ Test Result

image

@github-actions github-actions bot added chore Minor changes or maintenance tasks documentation Improvements or additions to documentation feature Adding a new feature test Adding or correcting existing tests labels Dec 12, 2024
@katsujukou katsujukou self-requested a review December 19, 2024 06:41
katsujukou
katsujukou reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@katsujukou katsujukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote some comments. Please check!

backend/oqtopus_cloud/provider/routers/jobs.py Outdated Show resolved Hide resolved
backend/oqtopus_cloud/provider/routers/jobs.py Outdated Show resolved Hide resolved
backend/oqtopus_cloud/provider/routers/jobs.py Outdated Show resolved Hide resolved
backend/oqtopus_cloud/provider/routers/jobs.py Outdated Show resolved Hide resolved
orangekame3
orangekame3 reviewed Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@orangekame3 orangekame3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanksγ€€@shgokita
I commented a little.

@github-actions github-actions bot added the refactor Code changes that neither fix a bug nor add a feature label Dec 26, 2024
@shgokita
Copy link
Contributor Author

Thank you for your review.
I think I have responded to all the comments.
Please confirm.
@katsujukou @orangekame3

katsujukou
katsujukou approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@katsujukou katsujukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

orangekame3
orangekame3 approved these changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@orangekame3 orangekame3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shgokita
Thanks, LGTM

@orangekame3 orangekame3 changed the title Feature/get jobs feat: add pagenation get jobs Dec 26, 2024
@orangekame3 orangekame3 changed the title feat: add pagenation get jobs feat: add pagination get jobs Dec 26, 2024
@orangekame3 orangekame3 merged commit e8492ac into develop Dec 26, 2024
2 checks passed
@orangekame3 orangekame3 deleted the feature/get-jobs branch December 26, 2024 09:20
@github-actions github-actions bot mentioned this pull request Dec 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katsujukou katsujukou katsujukou approved these changes

@orangekame3 orangekame3 orangekame3 approved these changes

Assignees

@shgokita shgokita

Labels
chore Minor changes or maintenance tasks documentation Improvements or additions to documentation feature Adding a new feature refactor Code changes that neither fix a bug nor add a feature test Adding or correcting existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shgokita @orangekame3 @katsujukou