docs: Added documentation for oci load balancer annotations #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the reference documentation for oci loadbalancer annotations Signed-off-by: Deepak Devadathan <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
hyder
reviewed
Jan 5, 2025
| @@ -0,0 +1,147 @@ | |||
| # Load Balancer Annotations | |||
|
|
|||
| This file defines a list of [Service][4] `type: LoadBalancer` annotations which are | |||
There was a problem hiding this comment.
Don't just copy from the OCI CCM docs. This will be published to github pages and not accessed by file. Rework the docs with publishing in mind.
hyder
reviewed
Jan 5, 2025
| # Load Balancer Annotations | ||
|
|
||
| This file defines a list of [Service][4] `type: LoadBalancer` annotations which are | ||
| supported by the `oci-cloud-controller-manager`. |
There was a problem hiding this comment.
Please add link to OCI CCM repo.
hyder
reviewed
Jan 5, 2025
| ... | ||
| ``` | ||
|
|
||
| ## Load balancer Type Annotation |
There was a problem hiding this comment.
Re-orgnanize the annotations by api group and pay particular attention to sec list vs nsg.
hyder
requested changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the reference documentation for oci loadbalancer annotations
This PR is for adding documentation reference for the supported oci loadbalancer annotations