Add deserialization tests for 4.3 protobufs in Core #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
…, datasets, hashers, sequence classes and weighted ensemble model.A
Craigacp
force-pushed
the
core-serialization
branch
from
4d6de77 to
55096d8
Compare
Classification/Core/src/main/java/org/tribuo/classification/ensemble/AdaBoostTrainer.java
Outdated
Show resolved
Hide resolved
…semble/AdaBoostTrainer.java Co-authored-by: Jack Sullivan <[email protected]>
JackSullivan
approved these changes
Dec 23, 2024
Craigacp
added a commit
that referenced
this pull request
Dec 23, 2024
* Adding tests for KNNModel, OCI converters, ONNX converters and TensorFlow converters. * Adding serialization tests for prediction, variable info, feature map, datasets, hashers, sequence classes and weighted ensemble model.A * Adding transform serialization tests. * Adding 4.3.1 protobufs, fixing a few bugs. * Updating protos. * More proto fixes. * Relaxing the tests slightly due to provenance checking in .equals(). * Fixing invalid OCI protobufs. * Update Classification/Core/src/main/java/org/tribuo/classification/ensemble/AdaBoostTrainer.java Co-authored-by: Jack Sullivan <[email protected]> --------- Co-authored-by: Jack Sullivan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #318 adds deserialization tests to Core and Interop.
Motivation
We will support 4.3 protobufs in v5 and need tests to ensure that the upcoming refactors don't break serialization compatibility.