Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking to add the ability to build TruffleRuby from source with a custom ruby-build definition. To make that simpler, I've added a new
--install
option tojt build
. Normally, ifjt build
detects a standard rbenv or chruby installation directory it establishes a symlink to the latest build there. The symlink approach doesn't work well for ruby-build since it does all of its compilation in a temporary directory. The newly added--install
directsjt build
to install the final artifact at the specified directory rather than establish a symlink.It is possible to achieve what I'm looking for without adding the new option. E.g., the truffleruby-dev-builder builds releases without
jt build
. But, this--install
option makes things a lot simpler in my opinion.I chose the name
--install
to match the convention of having amake
task named install. I could rename it to--prefix
if preferred since that's the term often used to specify themake install
target. As an another option, we could use the existing--name
option and if the name looks like a path use that to trigger a move rather than symlink. If we want to do something like that to reduce the number of options that's fine.