Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: credential not needed to update,version and help #104

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

dmicheneau
Copy link
Member

@dmicheneau dmicheneau commented Mar 26, 2024

Description of your changes

If you submit change in the provider code, please make sure to:

  • If Needed add a changelog file
  • Write or modify coverage tests
  • Run make generate to ensure the doc was updated properly

How has this code been coverage and tested

go test -coverprofile=coverage.out ./cmd/... && go tool cover -func=coverage.out

coverage: 55.5% of statements
ok      github.com/orange-cloudavenue/cloudavenue-cli/cmd       157.021s        coverage: 55.5% of statements
github.com/orange-cloudavenue/cloudavenue-cli/cmd/add.go:27:            init                    65.2%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/del.go:31:            init                    100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/get.go:45:            init                    100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root.go:16:           Execute                 50.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root.go:31:           NewRootCmd              100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root.go:36:           init                    100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root_client.go:16:    initConfig              47.8%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root_client.go:60:    initClient              75.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root_global.go:67:    stringToTypeFormat      75.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root_global.go:79:    timeTrack               100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/update.go:17:         init                    100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/version.go:5:         init                    100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/version.go:10:        versionCmd              100.0%
total:                                                                  (statements)            71.9%

@dmicheneau dmicheneau marked this pull request as ready for review March 26, 2024 13:33
@dmicheneau dmicheneau requested a review from a team as a code owner March 26, 2024 13:33
@dmicheneau dmicheneau merged commit cb5077d into main Mar 26, 2024
3 checks passed
@dmicheneau dmicheneau deleted the 78-bug-completion-require-credential branch March 26, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant