Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: credential not needed to update,version and help #95

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

dmicheneau
Copy link
Member

@dmicheneau dmicheneau commented Feb 14, 2024

Description of your changes

If you submit change in the provider code, please make sure to:

  • If Needed add a changelog file
  • Write or modify coverage tests
  • Run make generate to ensure the doc was updated properly

How has this code been coverage and tested

go test -coverprofile=coverage.out ./cmd/... && go tool cover -func=coverage.out

PASS
coverage: 62.1% of statements
ok      github.com/orange-cloudavenue/cloudavenue-cli/cmd       88.197s coverage: 62.1% of statements
github.com/orange-cloudavenue/cloudavenue-cli/cmd/create.go:35:         init                    65.2%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/del.go:39:            init                    100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/get.go:53:            init                    100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root.go:68:           Execute                 42.9%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root.go:84:           NewRootCmd              100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root.go:88:           timeTrack               100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root.go:93:           init                    100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root.go:100:          stringToTypeFormat      75.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root.go:112:          initConfig              45.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/root.go:151:          initClient              71.4%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/update.go:17:         init                    100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/version.go:5:         init                    100.0%
github.com/orange-cloudavenue/cloudavenue-cli/cmd/version.go:10:        versionCmd              100.0%
total:                                                                  (statements)            71.1%

@dmicheneau dmicheneau requested a review from a team as a code owner February 14, 2024 15:27
@cloudavenue-bot
Copy link

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

cmd/create_edgegateway.go Show resolved Hide resolved
cmd/root_global.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@dmicheneau dmicheneau force-pushed the 78-bug-completion-require-credential branch from 7e7988f to 7c31518 Compare February 19, 2024 14:36
@dmicheneau dmicheneau merged commit d4532bf into main Feb 19, 2024
6 of 7 checks passed
@dmicheneau dmicheneau deleted the 78-bug-completion-require-credential branch February 19, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants